-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDE metrics server #11542
IDE metrics server #11542
Conversation
Socket Security Report👍 No new dependency issues detected in pull request Socket.dev scan summary
Powered by socket.dev |
started the job as gitpod-build-pd-ide-metrics.10 because the annotations in the pull request description changed |
5c9e639
to
fa6a57e
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
9994d75
to
0183d20
Compare
Yes, so I put a hold label here, wait https://github.com/gitpod-io/ops/pull/3666 get merged first. Thanks 🙏 |
@mustard-mh It is alright. The goal of this PR is to bring IDE metrics component to production. We can work on concrete metrics later. |
Could you check how we do it in ws-manager please? 🙏 It can be another PR, let's create an issue for it for now. We need to land this PR to unblock #11910 |
ws-manager just rate limit for the method name https://github.com/gitpod-io/ops/blob/main/deploy/workspace/installer-values.yaml#L25-L32 because it client only |
Co-authored-by: Huiwen <mhqnwt@gmail.com>
@iQQBot We can do the same or on level of metric names? but let's do it later, we don't have anyone calling it yet so often, anyway |
Let's see how it looks in practice and then see how we can adjust ratelimit |
/unhold |
Description
This PR introduce a new component
ide-metrics
, which is a public endpoint, which can allow some short live client report metrics and error log (not in this PR)Related Issue(s)
Fix #11134
How to test
For test convenience I wrote some test clients, and they will be deleted before merge
gitpod.io
/workspace/gitpod/components/ide-metrics
go run main.go test-client
, you will seesend success
message./dev/preview/portforward-monitoring-satellite.sh -c harvester
to open promethuesgitpod_supervisor_frontend_error_total
is increase (There is an interval for scraping, you can refresh in 1min)another example:
Console
throw new Error("aa")
, them switch toNetwork
tab, you will seeAddCounter
requestgitpod_supervisor_frontend_error_total
should increaseRelease Notes
Documentation
Werft options: