[usage] Extend server args with time-filtering #11612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laushinka
force-pushed
the
laushinka/allow-users-to-switch-11526
branch
2 times, most recently
from
9fe46f6 to
794eb5f
Compare
laushinka
force-pushed
the
laushinka/allow-users-to-switch-11526
branch
from
794eb5f to
6bccc0b
Compare
|
started the job as gitpod-build-laushinka-allow-users-to-switch-11526.9 because the annotations in the pull request description changed |
laushinka
changed the title
laushinka
changed the title
easyCZ
approved these changes
Jul 25, 2022
easyCZ
reviewed
Jul 25, 2022
| @@ -293,7 +293,7 @@ export interface GitpodServer extends JsonRpcServer<GitpodClient>, AdminServer, | |||
| getSpendingLimitForTeam(teamId: string): Promise<number | undefined>; | |||
| setSpendingLimitForTeam(teamId: string, spendingLimit: number): Promise<void>; | |||
|
|
|||
| listBilledUsage(attributionId: string): Promise<BillableSession[]>; | |||
| listBilledUsage(attributionId: string, from?: number, to?: number): Promise<BillableSession[]>; | |||
There was a problem hiding this comment.
FYI, you can also pass in arguments for ordering, in case you wanted to implement ascending/descending
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the server with time-filtering args.
The client sends
numberand then it gets converted in the server togoogle.protobuf.Timestamp.Related Issue(s)
Relates #11526
How to test
Preview still renders and calls
listBilledUsagewith the time params (the websocket connection in the network tab).Release Notes
Documentation
Werft options: