[usage] Add BillingService with UpdateInvoices RPC #11650
Conversation
| google.protobuf.Timestamp start_time = 1; | ||
| google.protobuf.Timestamp end_time = 2; | ||
|
|
||
| repeated BilledSession sessions = 3; |
There was a problem hiding this comment.
As a client of this RPC I would assume I can:
- Give a start time and an end time and have invoices updated for all instances that ran in that time (maybe I'd like to give attributionIds too, so that I only update invoices for that team/user).
but here I can pass a list of BilledSessions as inputs (presumably intended to be those returned by the ListBilledUsage RPC on the usage service. What happens if I pass billed sessions that lie outside the time range?
There was a problem hiding this comment.
So this is not a general purpose RPC, in a way, it's an internal RPC. I can clarify in comments.
You're correct, this only makes sense in the context of another thing which produces the sessions. I'm not sure how to rename or better convey this but the intended usage is not outside callers without context, but the "usage reconcile run"
There was a problem hiding this comment.
I think some comments above the service to that effect would be good 👍
There was a problem hiding this comment.
When we do have authN in depth, I would've also encoded that the only caller of this RPC can be a service account which has the perms to generate usage reports, which I believe would've helped.
There was a problem hiding this comment.
Added a comment on the proto
easyCZ
force-pushed
the
mp/usage-billing-service
branch
from
578c317 to
8d604b7
Compare
roboquat
added
deployed: webapp
Description
To move the logic into an RPC, and decouple it from the Usage logic
Related Issue(s)
How to test
CI runs
Release Notes
Documentation
Werft options: