[usage] Add ReconcileUsage RPC #11676
Conversation
|
|
||
| // CollectUsage collects usage for the specified time period, and stores the usage records in the database, returning the records. | ||
| rpc CollectUsage(CollectUsageRequest) returns (CollectUsageResponse) {} |
There was a problem hiding this comment.
There is potential for confusion between this new RPC and the ListBilledUsage RPC above.
AIUI, ListBilledUsage retrieves usage records (within a time range, for an attribution id) that have already been computed.
This new RPC actually triggers the usage collection that will populate usage records that are then available to ListBilledUsage.
Maybe calling this one StartUsageReconciliation or something similar, to emphasise its imperative nature would be better?
There was a problem hiding this comment.
In theory, calling either should be fine as the end result is going to be some (accurate) records in the DB. The main difference is one is a pure read, while the other is an Upsert in a way.
If the RPC is called Start.., then I would expect it's an async job which it is not. Perhaps UpdateUsage?
There was a problem hiding this comment.
Or ReconcileUsage, as that's probs most accurate
|
/unhold |
roboquat
added
deployed: webapp
Description
Adds RPC definition for Collecting usage
Related Issue(s)
How to test
Release Notes
Documentation
Werft options: