Skip to content

[usage] Implement CollectUsage #11681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2022
Merged

[usage] Implement CollectUsage #11681

merged 1 commit into from
Aug 2, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jul 27, 2022 •
edited
Loading

Description

Moves the Usage Controller into an RPC called CollectUsage. This change gives us the following:

  • Better decoupling between usage and billing
  • Better observability through existing gRPC method monitoring
  • More flexible structure to move services around
  • Simplifies scheduled job to compute usage and update billing

Related Issue(s)

How to test

Unit tests

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview with-billing

Base automatically changed from mp/usage-collect-usage-proto to main July 27, 2022 09:35
@roboquat roboquat added size/XXL and removed size/M labels Jul 27, 2022
@easyCZ easyCZ force-pushed the mp/usage-collect-usage-impl branch from aeba354 to 25591c5 Compare July 27, 2022 09:37
@easyCZ easyCZ force-pushed the mp/usage-collect-usage-impl branch from 9ee5e46 to 4c72983 Compare July 27, 2022 11:54
@easyCZ
Copy link
Member Author

easyCZ commented Jul 27, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview with-billing

👍 started the job as gitpod-build-mp-usage-collect-usage-impl.8
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/usage-collect-usage-impl branch 2 times, most recently from e438004 to e737b17 Compare August 1, 2022 17:59
@easyCZ easyCZ force-pushed the mp/usage-collect-usage-impl branch from 9eeaca2 to 506f86a Compare August 1, 2022 18:48
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-usage-collect-usage-impl.15 because the annotations in the pull request description changed
(with .werft/ from main)

@easyCZ easyCZ marked this pull request as ready for review August 2, 2022 07:49
@easyCZ easyCZ requested a review from a team August 2, 2022 07:49
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 2, 2022
@easyCZ easyCZ force-pushed the mp/usage-collect-usage-impl branch from 506f86a to 706089e Compare August 2, 2022 08:08
@easyCZ easyCZ mentioned this pull request Aug 2, 2022
Merged
1 task
andrew-farries
andrew-farries approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for splitting out UsageReport

@easyCZ easyCZ force-pushed the mp/usage-collect-usage-impl branch from 706089e to eedac29 Compare August 2, 2022 11:15
@easyCZ
Copy link
Member Author

easyCZ commented Aug 2, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-preview with-billing

👍 started the job as gitpod-build-mp-usage-collect-usage-impl.18
(with .werft/ from main)

@easyCZ
Copy link
Member Author

easyCZ commented Aug 2, 2022

/unhold

@roboquat roboquat merged commit fc10f0b into main Aug 2, 2022
@roboquat roboquat deleted the mp/usage-collect-usage-impl branch August 2, 2022 11:53
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @andrew-farries @roboquat