Skip to content

[installer] Support configuration of the public API HTTP port #11832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ func configmap(ctx *common.RenderContext) ([]runtime.Object, error) {
GRPC: &baseserver.ServerConfiguration{
Address: fmt.Sprintf(":%d", GRPCContainerPort),
},
HTTP: &baseserver.ServerConfiguration{
Address: fmt.Sprintf(":%d", HTTPContainerPort),
},
},
},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ func TestConfigMap(t *testing.T) {
GRPC: &baseserver.ServerConfiguration{
Address: fmt.Sprintf(":%d", GRPCContainerPort),
},
HTTP: &baseserver.ServerConfiguration{
Address: fmt.Sprintf(":%d", HTTPContainerPort),
},
},
},
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@ const (
GRPCPortName = "grpc"
GRPCContainerPort = 9001
GRPCServicePort = 9001
HTTPContainerPort = 9002
HTTPServicePort = 9002
HTTPPortName = "http"
)
11 changes: 9 additions & 2 deletions install/installer/pkg/components/public-api-server/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,18 @@ import (
)

func service(ctx *common.RenderContext) ([]runtime.Object, error) {
return common.GenerateService(Component, []common.ServicePort{
servicePorts := []common.ServicePort{
{
Name: GRPCPortName,
ContainerPort: GRPCContainerPort,
ServicePort: GRPCServicePort,
},
})(ctx)
{
Name: HTTPPortName,
ContainerPort: HTTPContainerPort,
ServicePort: HTTPServicePort,
},
}

return common.GenerateService(Component, servicePorts)(ctx)
}