Skip to content

[werft] Set publicApi.httpPort #11833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Aug 3, 2022

Description

Configure the HTTP port on which the public API server listens in preview environments.

See #11832 for a description of what this port is for.

Related Issue(s)

Part of #10937

How to test

In the preview environment for this branch run kubectl describe cm public-api-server.

See that the following section is present in the config:

"http": {
   "address": ":9002"
}

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

Andrew Farries added 3 commits August 3, 2022 07:59
If set via experimental config, the http port should appear in the
configmap.
@andrew-farries andrew-farries requested review from a team August 3, 2022 08:43
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels Aug 3, 2022
@andrew-farries andrew-farries changed the base branch from main to af/configure-public-api-http-port August 3, 2022 08:44
@andrew-farries andrew-farries removed the request for review from a team August 3, 2022 08:44
@roboquat roboquat added size/XS and removed size/M labels Aug 3, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-set-public-api-http-port-in-preview.2 because the annotations in the pull request description changed
(with .werft/ from main)

@andrew-farries
Copy link
Contributor Author

/hold because based on #11832

@corneliusludmann corneliusludmann removed the team: delivery Issue belongs to the self-hosted team label Aug 3, 2022
@andrew-farries andrew-farries force-pushed the af/configure-public-api-http-port branch from 8874a39 to 7c7ac42 Compare August 4, 2022 06:17
Base automatically changed from af/configure-public-api-http-port to main August 4, 2022 06:36
@roboquat roboquat added size/M and removed size/XS labels Aug 4, 2022
@andrew-farries
Copy link
Contributor Author

Closing as this is no longer configurable. See this #11832 (comment) #11832.

@andrew-farries andrew-farries deleted the af/set-public-api-http-port-in-preview branch August 4, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants