Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] update stable code image to fix changelog related url not works #11877

Merged
merged 1 commit into from
Aug 4, 2022
Merged

[code] update stable code image to fix changelog related url not works #11877

merged 1 commit into from
Aug 4, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Aug 4, 2022 •
edited
Loading

Description

commit hash in PR is from this PR #11875 job https://werft.gitpod-dev.com/job/gitpod-build-hw-vs-build.0

Related Issue(s)

Fixes #

How to test

Release Notes

Fix in-product changelog relative URLs not working problem

Documentation

Werft options:

  • /werft with-preview

@mustard-mh mustard-mh requested a review from a team August 4, 2022 10:39
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-vs-stable.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

/hold

To test first

@mustard-mh mustard-mh force-pushed the hw/vs-stable branch 2 times, most recently from 089e951 to 5032c06 Compare August 4, 2022 10:55
@mustard-mh mustard-mh requested a review from a team August 4, 2022 11:12
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Aug 4, 2022
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Aug 4, 2022 •
edited
Loading

Previous PR #11875 is just for image build (build job success but prev env failed), we can ignore and close it, so I'm going to test in this PR following previous PR's How to test section

@mustard-mh
Copy link
Contributor Author

I tested and it worked, can someone approve this PR? @gitpod-io/engineering-ide

image

@mustard-mh
Copy link
Contributor Author

Ahh, also @gitpod-io/engineering-self-hosted

akosyakov
akosyakov approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified, working as advertised

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Aug 4, 2022 •
edited
Loading

It makes no sense to make team self-hosted to review vscode release, how can we improve it? cc @akosyakov @vulkoingim

Should we make this golden file belong to both of our teams?(it makes PR labels weird) Or have other ways?

@akosyakov
Copy link
Member

@mustard-mh you need to cc @corneliusludmann and @mrsimonemms

Aleksandar is from platform

@mustard-mh
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit d92593d into main Aug 4, 2022
@roboquat roboquat deleted the hw/vs-stable branch August 4, 2022 11:44
@roboquat roboquat added the deployed: IDE IDE change is running in production label Aug 4, 2022
@mustard-mh mustard-mh added deployed Change is completely running in production and removed team: delivery Issue belongs to the self-hosted team labels Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsimonemms mrsimonemms mrsimonemms approved these changes

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustard-mh @akosyakov @mrsimonemms @roboquat