Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: collect the user config in support bundles #11943

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Aug 6, 2022

Description

This is redacted to ensure that sensitive data is not included in the support bundles. Example from Fernando at Replicated

How to test

Deploy via KOTS and run a support bundle. Inspect files and look in kots-config/gitpod/kotsadm-*/stdout.txt. Anything sensitive will be replaced with ***HIDDEN***

Release Notes

[kots]: collect the user config in support bundles

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms requested a review from a team August 6, 2022 21:04
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Aug 6, 2022
@Pothulapati
Copy link
Contributor

Pothulapati commented Aug 8, 2022

/werft run publish-to-kots

👍 started the job as gitpod-build-sje-kots-get-config.1
(with .werft/ from main)

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and no questions about the functionality but about the values. Should we also include S3 Key ID's? as they are no use for us anyway 🤔

/hold on the same

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Aug 8, 2022

@Pothulapati I was 50/50 about the usernames but, since you've suggested it, I'll implement that as well 👍🏻

This is redacted to ensure that sensitive data is not included in the
support bundles
@mrsimonemms mrsimonemms force-pushed the sje/kots-get-config branch from 03f3d96 to 9457f01 Compare August 8, 2022 10:11
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Aug 8, 2022

@Pothulapati updated with your suggestion and now get this. Will remove hold

apiVersion: kots.io/v1beta1
kind: ConfigValues
metadata:
  creationTimestamp: null
spec:
  values:
    advanced_mode_enabled:
      default: "0"
    cert_manager_enabled:
      default: "1"
    cert_manager_issuer:
      default: ClusterIssuer
    cert_manager_issuer_name:
      value: gitpod-issuer
    component_proxy_service_serviceType: {}
    config_patch: {}
    customization_patch: {}
    db_cloudsql_enabled:
      default: "0"
    db_cloudsql_instance: {}
    db_encryption_keys: '***HIDDEN***'
    db_gcp_credentials: '***HIDDEN***'
    db_host: {}
    db_incluster:
      default: "1"
    db_password: '***HIDDEN***'
    db_port:
      value: "3306"
    db_username:
      value: gitpod
    domain:
      value: gitpod.domain.com
    openVsxUrl: {}
    reg_incluster:
      default: "1"
    reg_incluster_storage:
      default: none
    reg_incluster_storage_s3_accesskey: '***HIDDEN***'
    reg_incluster_storage_s3_bucketname: {}
    reg_incluster_storage_s3_endpoint:
      value: s3.amazonaws.com
    reg_incluster_storage_s3_region: {}
    reg_incluster_storage_s3_secretkey: '***HIDDEN***'
    reg_password: '***HIDDEN***'
    reg_server: {}
    reg_url: {}
    reg_username: {}
    ssh_gateway:
      default: "0"
    store_azure_access_key: '***HIDDEN***'
    store_azure_account_name: '***HIDDEN***'
    store_gcp_credentials: '***HIDDEN***'
    store_gcp_project: '***HIDDEN***'
    store_provider:
      default: incluster
    store_region: {}
    store_s3_access_key_id: '***HIDDEN***'
    store_s3_bucket: {}
    store_s3_endpoint:
      value: s3.amazonaws.com
    store_s3_secret_access_key: '***HIDDEN***'
    tls_ca_crt: '***HIDDEN***'
    tls_crt: '***HIDDEN***'
    tls_key: '***HIDDEN***'
    tls_self_signed_enabled:
      default: "0"
    user_management_block_enabled:
      default: "0"
    user_management_block_passlist: {}
status: {}

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants