Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] fix host value for Git Integrations #11993

Merged
merged 1 commit into from
Aug 9, 2022
Merged

[dashboard] fix host value for Git Integrations #11993

merged 1 commit into from
Aug 9, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Aug 9, 2022

if : is included, just the preview of the callback URL should be replaced with _, but not actual host value.

Description

Related Issue(s)

Aftermath of #11798

How to test

  1. When entering a host value for a new integration on Git Integration page with a colon included, e.g. example.com:8433, you should see:
  • example.com:8433 in host field
  • .../example.com_8433/callback in preview of the callback URL

Screen Shot 2022-08-09 at 13 23 04

  1. Try to use an actual host with a reachable port (but it doesn't has to be a real OAuth2 server running) and hit Activate Integration.
  • (ignoring the request error for non-existing OAuth2 server) verify that your browser got redirected to an URL with example.com:8433 as host and containing example.com_8433 in the query.

Screen Shot 2022-08-09 at 13 23 26

Release Notes

Fixes entering of colons in host on Git Integration page.

Documentation

Werft options:

  • /werft with-preview

@AlexTugarev AlexTugarev requested a review from a team August 9, 2022 10:51
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 9, 2022
@roboquat roboquat added the size/S label Aug 9, 2022
@AlexTugarev AlexTugarev requested a review from jankeromnes August 9, 2022 10:51
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Aug 9, 2022

/werft run

👍 started the job as gitpod-build-at-fix-host.1
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-at-fix-host.2 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add some tests for this? ie, turn the comment here into a test?

/hold

if `:` is included, just the preview of the callback URL should be replaced with `_`, but not actual host value.
@AlexTugarev
Copy link
Member Author

@andrew-farries, thanks for the nudge! done.

/hold cancel

@roboquat roboquat merged commit 5a88807 into main Aug 9, 2022
@roboquat roboquat deleted the at/fix-host branch August 9, 2022 16:15
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants