[UBP/baseserver] Allow gRPC server to receive much larger messages #12003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 9, 2022 11:16
Add a test to ensure that the gRPC server can receive very large message payloads. Use the billing RPC service `UpdateInvoices` RPC as the RPC to call as that is the one we see failing in production.
Allow the gRPC server to receive messages up to 100MB in size.
github-actions
bot
added
team: webapp
jenting
reviewed
Aug 9, 2022
| @@ -298,6 +298,7 @@ func (s *Server) initializeGRPC() error { | |||
| opts = append(opts, grpc.Creds(credentials.NewTLS(tlsConfig))) | |||
| } | |||
|
|
|||
| opts = append(opts, grpc.MaxRecvMsgSize(100*1024*1024)) | |||
There was a problem hiding this comment.
Can we not change the gRPC base server default message size and let the caller overwrite the default message size? Because this is an optional for all gRPC server, WDYT?
There was a problem hiding this comment.
Yes, we can probably provide an option to set this.
The question is whether a user of the baseserver would ever care that the maximum message size was too large. IMO, probably not in which case an option is not needed. Perhaps we should add the option when it's needed.
jenting
approved these changes
Aug 9, 2022
AlexTugarev
approved these changes
Aug 9, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase baseserver's gRPC maximum receivable message size to 100MB. Change the
usageclient's maximum send and receive values to the same size.The usage component is currently failing with this error:
This change should allow the
UpdateInvoicesRPC (and all other gRPC services registered withbaseserver) to accept larger message sizes.Related Issue(s)
Fixes #11997
How to test
Release Notes
Documentation
Werft options: