Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JetBrains] Make new features available in stable version #12159

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[JetBrains] Make new features available in stable version #12159

merged 1 commit into from
Aug 19, 2022

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Aug 16, 2022 •
edited
Loading

Description

Moving ready features from latest to stable

Related Issue(s)

Fixes #12156

How to test

  1. Launch a workspace in prev env using JetBrains stable
  2. Open a repository that has multiple tasks defined (like gitpod repo)
  3. Make sure the following features are available:
    • CPU/Memory visible in Backend Control Center
    • Confirm if a terminal widget appears for each task defined on .gitpod.yml

Release Notes

JetBrains: Display Workspace CPU/Memory usage in Backend Control Center.
JetBrains: Workspaces created from repositories with tasks defined on .gitpod.yml will start with one terminal opened for each task.

Documentation

Werft options:

  • /werft with-preview

@andreafalzetti andreafalzetti self-assigned this Aug 16, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-andreafalzetti-jetbrains-move-all-12156.1 because the annotations in the pull request description changed
(with .werft/ from main)

@andreafalzetti andreafalzetti force-pushed the andreafalzetti/jetbrains-move-all-12156 branch from fd979e7 to e0db7eb Compare August 16, 2022 15:52
@roboquat roboquat added size/L and removed size/XS labels Aug 16, 2022
@andreafalzetti andreafalzetti force-pushed the andreafalzetti/jetbrains-move-all-12156 branch 2 times, most recently from 7aa7fef to f762779 Compare August 17, 2022 11:59
@andreafalzetti andreafalzetti changed the title feat: move new jetbrains features to stable [JetBrains] Make new features available in stable version Aug 17, 2022
@andreafalzetti andreafalzetti marked this pull request as ready for review August 17, 2022 13:03
@andreafalzetti andreafalzetti requested a review from a team August 17, 2022 13:03
@akosyakov akosyakov requested a review from felladrin August 17, 2022 13:12
@akosyakov
Copy link
Member

@andreafalzetti actually following feature should not available:

Auto Forward Task Terminal Ports

We move multiple terminals and workspace metrics. We should also update release notes with it.

@andreafalzetti
Copy link
Contributor Author

@akosyakov How can I determine what features should be moved? I am looking at merged PRs, but it's a bit messy. I thought ports tunneling and ports forwarding were 2 different things.

I will update the PR desc, but are the files I moved correct?

@akosyakov
Copy link
Member

@akosyakov How can I determine what features should be moved? I am looking at merged PRs, but it's a bit messy. I thought ports tunneling and ports forwarding were 2 different things.

@andreafalzetti Sorry for not being clear anything related to port forwarding should not go yet to stable. It is no complete. We don't have any UI either on terminals or generally to see these ports.

felladrin
felladrin suggested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment about moving a <projectService> to the other XML file.

After it's moved you can test it like this:

  • Open Preview Environment of this PR
  • Select Stable version of JetBrains IntelliJ IDEA as the editor
  • Open a repository that has multiple tasks defined (like gitpod repo)
  • Confirm if a terminal widget appears for each task defined on .gitpod.yml

Then this PR should be good to be merged :)

components/ide/jetbrains/backend-plugin/src/main/resources-latest/META-INF/extensions.xml Outdated Show resolved Hide resolved
@andreafalzetti andreafalzetti force-pushed the andreafalzetti/jetbrains-move-all-12156 branch from f762779 to 49c6257 Compare August 18, 2022 08:49
@akosyakov akosyakov requested a review from felladrin August 18, 2022 09:50
@andreafalzetti andreafalzetti force-pushed the andreafalzetti/jetbrains-move-all-12156 branch from 49c6257 to 4bc195b Compare August 18, 2022 12:41
@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Aug 18, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-andreafalzetti-jetbrains-move-all-12156.7
(with .werft/ from main)

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Aug 18, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-andreafalzetti-jetbrains-move-all-12156.8
(with .werft/ from main)

felladrin
felladrin approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! ✅

image

I'm going to leave it on hold in case you want to fix the typo mentioned in the previous message. Feel free to unhold when it's ready!

/hold

@andreafalzetti andreafalzetti force-pushed the andreafalzetti/jetbrains-move-all-12156 branch from 4bc195b to 85974a8 Compare August 18, 2022 20:35
@andreafalzetti
Copy link
Contributor Author

/unhold

@andreafalzetti
Copy link
Contributor Author

/hold

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Aug 18, 2022 •
edited
Loading

We should also update release notes with it.

@akosyakov I've added release notes about the workspace CPU/Memory in the related PR - do we need to write once more the release notes? (I don't think so but since it was mentioned I holded the PR 🤔 )

I am not sure about the terminal's PR cc @felladrin

@akosyakov
Copy link
Member

akosyakov commented Aug 19, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Before these features were not available in stable versions, only in latest. I think availability of a feature for all users if is important note.

@felladrin
Copy link
Contributor

Here's a suggestion for the release note about multiple terminals:

When using one of the JetBrains IDEs, workspaces created from repositories with tasks defined on .gitpod.yml will start with one terminal opened for each task.

@andreafalzetti
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit b4edca5 into main Aug 19, 2022
@roboquat roboquat deleted the andreafalzetti/jetbrains-move-all-12156 branch August 19, 2022 08:12
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov left review comments

@felladrin felladrin felladrin approved these changes

Assignees

@andreafalzetti andreafalzetti

Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note size/L team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jetbrains] move all features besides port tunnelling to stable
4 participants
@andreafalzetti @akosyakov @felladrin @roboquat