-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jetbrains): avoid connection loops #12232
Conversation
started the job as gitpod-build-fix-jb-connections-loop-9848.1 because the annotations in the pull request description changed |
...rains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodConnectionProvider.kt
Outdated
Show resolved
Hide resolved
...rains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodConnectionProvider.kt
Outdated
Show resolved
Hide resolved
0160863
to
39eb65e
Compare
3a9b57d
to
fa8f597
Compare
35c718f
to
859fdac
Compare
...rains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodConnectionProvider.kt
Outdated
Show resolved
Hide resolved
859fdac
to
e57420c
Compare
bd10ff0
to
0b3d189
Compare
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-fix-jb-connections-loop-9848.13 |
0b3d189
to
9b285ed
Compare
6930092
to
c7321a6
Compare
...rains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodConnectionProvider.kt
Outdated
Show resolved
Hide resolved
c7321a6
to
0e7c17c
Compare
0e7c17c
to
ddeed4a
Compare
...rains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodConnectionProvider.kt
Show resolved
Hide resolved
ddeed4a
to
60f0428
Compare
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-fix-jb-connections-loop-9848.22 |
/werft run with-clean-slate-deployment with-large-vm 👍 started the job as gitpod-build-fix-jb-connections-loop-9848.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks folks 🙏 /unhold |
Description
Adds a check to make sure to avoid connecting multiple times to the same workspace. Not having this check in place is causing a loop of connections when trying to open a connection with a workspace that is already opened in another client.
The approach used is to show this message popup while we wait for a new API to request focus to the open IDE.
Related Issue(s)
Fixes #9848
How to test
Optionally,
Release Notes
Documentation
Werft options: