Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[installer-tests] Adding test support for s3 registry backend #12252

Merged
merged 1 commit into from
Sep 1, 2022
Merged

[installer-tests] Adding test support for s3 registry backend #12252

merged 1 commit into from
Sep 1, 2022
+48 −8

Conversation

nandajavarma
Copy link
Contributor

@nandajavarma nandajavarma commented Aug 22, 2022 •
edited
Loading

Description

This PR adds the automated test for s3 used as registry backend in EKS cluster setup for Gitpod. As of the current test setup, when incluster registry is used, automatically s3 registry backend config will be chosen for testing.

Related Issue(s)

Fixes #11269

How to test

You can the following command, opening this PR in a gitpod workspace to trigger this test:

   werft run github -j .werft/eks-installer-tests.yaml -a deps=incluster

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma nandajavarma force-pushed the nvn/s3-backend-test branch 3 times, most recently from 432a7df to 40abd29 Compare August 22, 2022 09:09
@nandajavarma nandajavarma marked this pull request as ready for review August 22, 2022 10:31
@nandajavarma nandajavarma requested a review from a team August 22, 2022 10:31
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Aug 22, 2022
@adrienthebo adrienthebo self-assigned this Aug 24, 2022
@adrienthebo
Copy link
Contributor

My attempt to test this failed with the following, can you TAL?

Error:   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6312  100  6312    0     0  71727      0 --:--:-- --:--:-- --:--:-- 71727
bash: line 1: syntax error near unexpected token `newline'
bash: line 1: `<!DOCTYPE html>'
make: *** [Makefile:271: install-kots-cli] Error 2

Trying to send slack alert
tracing warning: No slice span by name create-aws-infra

@nandajavarma
Copy link
Contributor Author

Hey @adrienthebo ! Thanks for the review. Looks like this probably was an upstream KOTS install error that existed momentarily? This is passing now https://werft.gitpod-dev.com/job/gitpod-custom-nvn-s3-backend-test.11

@roboquat roboquat merged commit 1dfdf6e into main Sep 1, 2022
@roboquat roboquat deleted the nvn/s3-backend-test branch September 1, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsimonemms mrsimonemms mrsimonemms approved these changes

Assignees

@adrienthebo adrienthebo

Labels
release-note-none size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated testing with S3 backed in-cluster registry
4 participants
@nandajavarma @adrienthebo @mrsimonemms @roboquat