Skip to content

Remove code cli from path #12255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove code cli from path #12255

wants to merge 1 commit into from

Conversation

jeanp413
Copy link
Member

Description

Do not add code cli to path, vscode adds it to the terminals env internally

How to test

  1. Print env and check /ide/bin/remote-cli is not in the path

Release Notes

NONE

Werft options:

  • /werft with-preview

@akosyakov
Copy link
Member

akosyakov commented Aug 22, 2022

What about task terminals? They are not created by VS Code but supervisor.

@jeanp413
Copy link
Member Author

Right, forgot about this 🤦.
But then I would use this as an excuse to ask, does it really make sense for task terminals to be writable? I think it makes more sense for them to be readonly and use the vscode task API instead. And then, it will complement with gp task stop command and we also need to add a gp task run and corresponding vscode commands same in jetbrains

@akosyakov
Copy link
Member

But then I would use this as an excuse to ask, does it really make sense for task terminals to be writable?

I don't think we can change it now. If there is some new consistent approach to consider I guess we need to start with RFC.

@jeanp413
Copy link
Member Author

closing this for now then

@jeanp413 jeanp413 closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants