Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[terraform] Updating terraform GCP module #12273

Merged
merged 3 commits into from
Aug 26, 2022
Merged

[terraform] Updating terraform GCP module #12273

merged 3 commits into from
Aug 26, 2022

Conversation

nandajavarma
Copy link
Contributor

@nandajavarma nandajavarma commented Aug 22, 2022 •
edited
Loading

Description

This PR makes some small changes to GKE terraform module, making it in sync with the reference architecture. The following are the changes:

  • Delete the default node pool and create a separate one for services workload, since this is what is being done in the reference architrecture
  • Set the node count for both services and workspaces workloads
  • some minor changes to the terraform output

Related Issue(s)

Fixes #

How to test

Please follow the GCP README to test this.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma nandajavarma marked this pull request as ready for review August 24, 2022 08:34
@nandajavarma nandajavarma requested a review from a team August 24, 2022 08:34
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Aug 24, 2022
@roboquat roboquat added size/L and removed size/M labels Aug 25, 2022
@nandajavarma @lucasvaltl
Update default workspace image size
a66446f 
Co-authored-by: Lucas Valtl <lucasvaltl@users.noreply.github.com>
@adrienthebo
Copy link
Contributor

/hold

@nandajavarma
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 979a6ea into main Aug 26, 2022
@roboquat roboquat deleted the nvn/fix-gcp-tf branch August 26, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienthebo adrienthebo adrienthebo approved these changes

@lucasvaltl lucasvaltl Awaiting requested review from lucasvaltl

Assignees
No one assigned
Labels
release-note-none size/L team: delivery Issue belongs to the self-hosted team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nandajavarma @adrienthebo @lucasvaltl @roboquat