[content-service] Define UsageReportService.DownloadURL rpc #12300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
requested review from
csweichel,
geropl and
corneliusludmann
as code owners
easyCZ
force-pushed
the
mp/content-get-download-url
branch
3 times, most recently
from
61355ae to
b5a7a2f
Compare
|
/werft run 👍 started the job as gitpod-build-mp-content-get-download-url.4 |
1 task
jenting
reviewed
Aug 24, 2022
easyCZ
force-pushed
the
mp/content-get-download-url
branch
from
b5a7a2f to
6c144ec
Compare
easyCZ
changed the title
easyCZ
force-pushed
the
mp/content-get-download-url
branch
from
6c144ec to
85dc4fb
Compare
jenting
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of marking Workspace Instances as already billed, we'll need to download the latest report an invoice is based on, and from that report mark all instances for that invoice as already billed for.
This PR adds the RPC definition without actually implementing it, that will come in subsequent PR.
What is the security model for content-service?
Related Issue(s)
How to test
NONE
Release Notes
Documentation
Werft options: