-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Implement EntitlementServiceUBP.hasPaidSubscription #12305
Conversation
abb7c71
to
f3d8a78
Compare
Hmm, I thought we'd be able to test the Usage-Based free tier, but since it's not implemented, we can't (so I crossed out steps 2 and 3 in the test plan): Also, unrelatedly, while opening several workspaces, I got a few of these error pages too. Looks like this retryAfter mechanism isn't properly supported in |
Hmm, I wasn't able to extend my workspace timeout (no clock button) 🤔 I guess this isn't quite ready yet & needs more debugging. EDIT: Hmm, of course, when you add debug logs, then it works 100% fine. 🙄 ✅ |
2092c32
to
a3c6053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 to unblock!
Maybe it would be good to simplify the promise races here ;-)
/hold
a3c6053
to
69f7c88
Compare
Thanks! Good suggestion -- adjusted the code, and tested again, still works as intended. 🚀 /unblock |
/unhold I think that's what @jankeromnes wanted to do here. |
Description
hasPaidSubscription
logic inEntitlementServiceUBP
.Drive-by fix:
userGetsMoreResources
with usage-based billing (but it's still used by Chargebee customers)Related Issue(s)
Fixes #12169
How to test
Try starting multiple workspaces in parallel -- at 4 parallel workspaces, you should start seeing a paywall that prevents you from starting more (until the currently-running workspaces are stopped again)Once a workspace is running, you should not be able to extend the workspace timeout (i.e. no "clock" button in the IDE bottom bar)Release Notes
Documentation
Werft options: