Skip to content

[server] Remove outdated feature flag deprecateOldImageLogsMechanism #12351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2022
Merged

[server] Remove outdated feature flag deprecateOldImageLogsMechanism #12351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions components/server/src/workspace/gitpod-server-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1583,31 +1583,11 @@ export class GitpodServerImpl implements GitpodServerWithTracing, Disposable {

const logInfo = instance.imageBuildInfo?.log;
if (!logInfo) {
const teams = await this.teamDB.findTeamsByUser(user.id);
const isOldImageBuildLogsMechanismDeprecated = await getExperimentsClientForBackend().getValueAsync(
"deprecateOldImageLogsMechanism",
false,
{
user,
projectId: workspace.projectId,
teams,
},
log.error(logCtx, "cannot watch imagebuild logs for workspaceId: no image build info available");
throw new ResponseError(
ErrorCodes.HEADLESS_LOG_NOT_YET_AVAILABLE,
"cannot watch imagebuild logs for workspaceId",
);
if (isOldImageBuildLogsMechanismDeprecated) {
log.error(logCtx, "cannot watch imagebuild logs for workspaceId: no image build info available");
throw new ResponseError(
ErrorCodes.HEADLESS_LOG_NOT_YET_AVAILABLE,
"cannot watch imagebuild logs for workspaceId",
);
}

// during roll-out this is our fall-back case.
// Afterwards we might want to do some spinning-lock and re-check for a certain period (30s?) to give db-sync
// a change to move the imageBuildLogInfo across the globe.
log.warn(logCtx, "imageBuild logs: fallback!");
ctx.span?.setTag("workspace.imageBuild.logs.fallback", true);
await this.deprecatedDoWatchWorkspaceImageBuildLogs(ctx, logCtx, user, workspace);
return;
}

const aborted = new Deferred<boolean>();
Expand Down