Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitpod-protocol] add missing method in golang #12354

Merged
merged 1 commit into from
Aug 25, 2022
Merged

[gitpod-protocol] add missing method in golang #12354

merged 1 commit into from
Aug 25, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Aug 24, 2022

Description

Add missing function getSupportedWorkspaceClasses for golang lib

Previous PR of PR #12338

Related Issue(s)

Fixes #

How to test

Test in PR #12338 which based on this branch hw/ws-cls

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@mustard-mh mustard-mh marked this pull request as ready for review August 25, 2022 03:42
@mustard-mh mustard-mh requested a review from a team August 25, 2022 03:42
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 25, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-ws-cls.2 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka laushinka self-assigned this Aug 25, 2022
@laushinka
Copy link
Contributor

Taking a look! Creating a preview env to test as described in the other PR's How-to-test[1]

@roboquat roboquat merged commit cbe7c8c into main Aug 25, 2022
@roboquat roboquat deleted the hw/ws-cls branch August 25, 2022 10:36
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants