[kots] load dockerConfigJson reigstry names into privateBaseImageAllowList
#12398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: delivery
Contributor
Author
|
/werft run publish-to-kots 👍 started the job as gitpod-build-tar-reg-private-list.1 |
Contributor
|
We should likely also call out that these will be added to the allow list via a small disclaimer in the installation Ui. What happens if a user also adds them to the allowlist themselves - will it break if things are in there twice? :) |
mrsimonemms
suggested changes
Aug 26, 2022
nandajavarma
force-pushed
the
tar/reg-private-list
branch
2 times, most recently
from
9eeeab0 to
84f1e48
Compare
Contributor
mrsimonemms
reviewed
Aug 26, 2022
Contributor
|
/hold while we await the doc |
nandajavarma
force-pushed
the
tar/reg-private-list
branch
from
534ed90 to
dbc22a7
Compare
…owList` Follow upto #12174 This PR updates the installer logic to also load the auth's reigstry URL's into `.containerRegistry.privateBaseImageAllowList`. Signed-off-by: Tarun Pothulapati <tarun@gitpod.io> Co-authored-by: Simon Emms <simon@gitpod.io> Co-authored-by: Nandaja Varma <nandaja.varma@gmail.com>
nandajavarma
force-pushed
the
tar/reg-private-list
branch
from
dbc22a7 to
b12cf31
Compare
mrsimonemms
approved these changes
Aug 26, 2022
Contributor
mrsimonemms
left a comment
mrsimonemms
left a comment
There was a problem hiding this comment.
You may remove the hold at will
Contributor
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow upto #12174
This PR updates the installer logic to also load the auth's reigstry
URL's into
.containerRegistry.privateBaseImageAllowList.Signed-off-by: Tarun Pothulapati tarun@gitpod.io
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: