Fix AccountStatementProvider #12431
Merged
Fix AccountStatementProvider #12431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-gpl-fix-accountstatement.1 because the annotations in the pull request description changed |
AlexTugarev
reviewed
Aug 26, 2022
AlexTugarev
reviewed
Aug 26, 2022
|
/werft run 👍 started the job as gitpod-build-gpl-fix-accountstatement.2 |
|
/hold Because of ongoing testing |
geropl
force-pushed
the
gpl/fix-accountstatement
branch
3 times, most recently
from
20106df to
2220e35
Compare
AlexTugarev
reviewed
Aug 26, 2022
|
/werft run 👍 started the job as gitpod-build-gpl-fix-accountstatement.6 |
AlexTugarev
approved these changes
Aug 29, 2022
geropl
force-pushed
the
gpl/fix-accountstatement
branch
from
2220e35 to
901cbb0
Compare
geropl
force-pushed
the
gpl/fix-accountstatement
branch
from
901cbb0 to
e0c24f1
Compare
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes caching issue withing AccountStatementProvider. The reasons for this PR is a refactoring 2 weeks back which slightly broke the credit limit check; this PR is meant to bring it back.
Related Issue(s)
Fixes #
How to test
INSERT INTO d_b_account_entry SET uid = '<some-id>', userId = '<your-userId>', amount = -50, date = '2022-08-26T13:47:36.360Z', expiryDate ='2022-10-26T13:47:36.360Z', kind = 'credit';@AlexTugarev Already did this for your user
Release Notes
Documentation
Werft options: