Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code-sync: store editSessions #12445

Merged
merged 1 commit into from
Sep 8, 2022
Merged

code-sync: store editSessions #12445

merged 1 commit into from
Sep 8, 2022

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Aug 26, 2022 •
edited by filiptronicek
Loading

Description

Store editSessions in sync server

How to test

  1. Create workspace using latest vscode
  2. Test editsessions is working https://code.visualstudio.com/updates/v1_70#_edit-sessions-across-vs-code-for-the-web-and-desktop, in our case it could used to store changes between new workspaces of the same repo

Release Notes

Support for storing VS Code edit sessions in sync server

Werft options:

  • /werft with-preview

@jeanp413
Copy link
Member Author

jeanp413 commented Aug 29, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-sync-profile.6
(with .werft/ from main)

@jeanp413 jeanp413 marked this pull request as ready for review August 29, 2022 04:07
@jeanp413 jeanp413 requested a review from a team August 29, 2022 04:07
@jeanp413
Copy link
Member Author

jeanp413 commented Aug 29, 2022 •
edited
Loading

Not sure why the ci/werft/build — The build failed! link below redirects to main build, but you can look for the correct build in werft https://werft.gitpod-dev.com/job/gitpod-build-jp-sync-profile.7

@jeanp413 jeanp413 requested a review from a team August 29, 2022 04:10
@mustard-mh
Copy link
Contributor

werft run

@mustard-mh
Copy link
Contributor

mustard-mh commented Aug 29, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-sync-profile.8
(with .werft/ from main)

@akosyakov
Copy link
Member

akosyakov commented Aug 29, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@jeanp413 Does it bring any user facing changes for Gitpod users? if so please update release notes. 🙏

filiptronicek
filiptronicek reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeanp413 thanks a lot for taking time to support this cool thingy. I am a bit confused in how the user is supposed to work with them.

I executed the command to store the edit session, then opened a workspace with the same repo and did Continue Edit session, but I got this:
image

When actioning on the only item here VS Code wants to open vscode.dev
image

@jeanp413
Copy link
Member Author

Good catch I'll remove that vscode.dev option xD

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 2, 2022

@filiptronicek I removed the open in vscode.dev option but now the quick pick will be empty that's expected, we can't support vscode desktop as there's no way to configure the edit sessions server like we do with settings sync server

filiptronicek
filiptronicek approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + tests all look good, I can Resume latest Edit Session just fine (see screenshot). This feature is great - it's like a synced git stash!
image

I am not sure @jeanp413 how you made the vscode.dev option disappear, but could we make the Sign in, Sign out actions disappear too (we do that automatically, don't we?)? Removing the whole Continue Edit Session... would probably be nice as well if we don't have any options now.

image

/hold for others to review + if you want to integrate some of my suggestions 😊

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 7, 2022

could we make the Sign in, Sign out actions disappear too (we do that automatically, don't we?)?

yeah experience is still rough in upstream vscode as is still experimental, will look into fixing it upstream if I find some free time

@akosyakov
Copy link
Member

akosyakov commented Sep 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@jeanp413 @filiptronicek Please update release notes section before merging 👋

@jeanp413
Copy link
Member Author

jeanp413 commented Sep 8, 2022

/unhold

@roboquat roboquat merged commit eb9aaa9 into main Sep 8, 2022
@roboquat roboquat deleted the jp/sync-profile branch September 8, 2022 16:47
@filiptronicek filiptronicek added component: server team: IDE deployed Change is completely running in production labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustard-mh mustard-mh mustard-mh left review comments

@andrew-farries andrew-farries andrew-farries approved these changes

@filiptronicek filiptronicek filiptronicek approved these changes

Assignees
No one assigned
Labels
component: server deployed Change is completely running in production release-note size/L team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeanp413 @mustard-mh @akosyakov @andrew-farries @filiptronicek @roboquat