[ws-manager] improve finalizeWorkspaceContent logic #12450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
finalizeWorkspaceContent
is running for a given workspace. This fixes various race conditions, wherefinalizeWorkspaceContent
may get called multiple times (one after another), and each call will attempt to dispose workspace, causing second and any after call to fail, since workspace was already disposed.Related Issue(s)
Fixes #11710
How to test
Start and stop workspaces.
Start workspaces that fail during init, and ensure this is handled correctly.
Release Notes
Documentation
Werft options: