Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[public-api] Fix stripe webhook secret mounting #12502

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Aug 30, 2022

Description

Ensures that only the key stripe-webhook-secret from the secret stripe-webhook-secret is mounted as a file, not as a directory with all keys in the secret.

See https://stackoverflow.com/questions/65399714/what-is-the-difference-between-subpath-and-mountpath-in-kubernetes

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@easyCZ easyCZ requested a review from a team August 30, 2022 08:09
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team and removed size/XS labels Aug 30, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-papi-stripe-secret-subpath.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/S and removed size/XS labels Aug 30, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works

@roboquat roboquat merged commit c2b7421 into main Aug 30, 2022
@roboquat roboquat deleted the mp/papi-stripe-secret-subpath branch August 30, 2022 08:58
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants