Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] do not change ready file to /.workspace folder #12526

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Aug 30, 2022

Description

This is a bug, as ready file will never actually be placed into /.workspace folder, it will always be in /workspace

Related Issue(s)

Related to #12464

How to test

Enable PVC feature
Start and stop workspaces (from prebuild, and normal)

Release Notes

none

Documentation

Werft options:

  • /werft with-preview

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-pavel-pvc-ready-file.1 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting marked this pull request as ready for review August 30, 2022 23:10
@jenting jenting requested a review from a team August 30, 2022 23:10
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /.workspace/.gitpod/ready file is never generated, so removing this line is good to me.
I've tested against prebuild and normal workspace.

@roboquat roboquat merged commit 7aa2d43 into main Aug 30, 2022
@roboquat roboquat deleted the pavel/pvc-ready-file branch August 30, 2022 23:33
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants