Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Add name of blocked account when trying to run prebuilds #12533

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[server] Add name of blocked account when trying to run prebuilds #12533

merged 1 commit into from
Aug 31, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 30, 2022

Description

Error log for blocked accounts do not show any detail Error: Blocked users cannot start prebuilds

How to test

  • Use a blocked account to run a prebuild
  • Search the logs. The message should include the name

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf aledbf requested a review from a team August 30, 2022 23:25
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 30, 2022
geropl
geropl approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit f019941 into main Aug 31, 2022
@roboquat roboquat deleted the aledbf/sbp branch August 31, 2022 07:19
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @geropl @roboquat