Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Allow manual user verification #12542

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[admin] Allow manual user verification #12542

merged 1 commit into from
Aug 31, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Aug 31, 2022 •
edited
Loading

Description

Allows to verify a user manually.

Related Issue(s)

fixes #12540

How to test

Login with a new github user and use a different admin account to verify that user.

https://www.loom.com/share/eab41b81a50d4e859245de0bc3b4e469

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@svenefftinge svenefftinge requested a review from a team August 31, 2022 10:31
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 31, 2022
@svenefftinge
Copy link
Member Author

svenefftinge commented Aug 31, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-sefftinge-admin-allow-manually-12540.2
(with .werft/ from main)

@jldec
Copy link
Contributor

jldec commented Aug 31, 2022

LGTM - works as advertised

  • signup as new GH user
  • see verification prompt when starting a workspace
  • from admin dashboard, click "Verify User" button - see verified tag
  • new GH user can now open workspace without additional verification

jldec
jldec approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 9dfafc0 into main Aug 31, 2022
@roboquat roboquat deleted the sefftinge/admin-allow-manually-12540 branch August 31, 2022 17:12
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldec jldec jldec approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Admin] Allow manually verify users
3 participants
@svenefftinge @jldec @roboquat