Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ops] WebApp: Fix team-specific alerts #12588

Merged
merged 3 commits into from
Sep 2, 2022
Merged

[ops] WebApp: Fix team-specific alerts #12588

merged 3 commits into from
Sep 2, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 1, 2022 •
edited
Loading

Description

Fixes very noisy alerts introduced with #12514, mostly because I learned that rate(gauge) does not work, especially not across different implementations (prometheus vs VictoriaMetrics).

Related Issue(s)

Context: #10722

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl geropl marked this pull request as ready for review September 1, 2022 15:50
@geropl geropl requested a review from a team September 1, 2022 15:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 1, 2022
@geropl geropl changed the title Gpl/alerts [ops] WebApp: Fix team-specific alerts Sep 1, 2022
@geropl geropl mentioned this pull request Sep 1, 2022
Closed
10 tasks
easyCZ
easyCZ approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip for making the reviewer's life easier:

  • 1 alert change per PR
  • Link to grafana with the query and/or screenshot it against a previous incident/threshold

/hold in case you want to make any other changes based on other feedback

@geropl
Copy link
Member Author

geropl commented Sep 2, 2022

/unhold

Already addressed comments,

@roboquat roboquat merged commit 81c5061 into main Sep 2, 2022
@roboquat roboquat deleted the gpl/alerts branch September 2, 2022 08:02
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens left review comments

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geropl @easyCZ @ArthurSens @roboquat