Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] update code stable to align all proposal apis #12607

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Sep 2, 2022

Description

Update code stable to align all proposal apis, code changes according to Werft result of branch which point codeCommit to gp-code/release/1.71 [1]

Related Issue(s)

Relates #12470

How to test

  • Open workspace in prev env with stable code
  • Check if commit hash in About is d96dc4787a7132bffb7d736e96a0b73469a9517e
  • Check Output section in terminal area, search with js-debug confirm that there is no errors about it

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@mustard-mh
Copy link
Contributor Author

mustard-mh commented Sep 2, 2022

/hold

/werft run

👍 started the job as gitpod-build-hw-vs-171-2.1
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

image

@mustard-mh
Copy link
Contributor Author

@iQQBot Are you still available to review? I have post the test result in comment

@mustard-mh
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit aaca753 into main Sep 2, 2022
@roboquat roboquat deleted the hw/vs-171-2 branch September 2, 2022 02:52
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/S team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants