[terraform] Turn off node auto-provisioning in GKE #12608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables auto-provisioning of nodes in GKE clusters. It turns out
cluster_autoscalinginfacts turns auto provisioning on. So all that is needed to enable autoscaling of nodes in GKE is to set theautoscalingsection in node pool resources.I am also pushing in a small change that enables Local DNS caching. This is currently enabled in the reference architecture, and this PR makes it consistent.
Thanks a lot to @lucasvaltl for catching it!!
Related Issue(s)
Fixes #12587
How to test
Please follow the README of the gcp module.
Release Notes
Documentation
Werft options: