Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Update dev-environment image and switch to gke-gcloud-auth-plugin #12641

Merged
merged 3 commits into from
Sep 8, 2022
Merged

[dev] Update dev-environment image and switch to gke-gcloud-auth-plugin #12641

merged 3 commits into from
Sep 8, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Sep 5, 2022

Description

This PR upgrade gcloud to version 400, it allows direct open auth page and copy auth code, no need copy gcloud command into local machine

berore after
image image

Also switch gcp auth provider to gke-gcloud-auth-plugin in order to remove deprecated warning

Berore After
image image

Related Issue(s)

Fixes #

How to test

  1. Open this branch in gitpod.io
  2. try kubectx dev && kubectl get pods, it should be no deprecated warning
  3. try gcloud auth login it should be allow direct open auth page

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@iQQBot iQQBot marked this pull request as ready for review September 5, 2022 04:58
@iQQBot iQQBot requested review from a team September 5, 2022 04:58
@github-actions github-actions bot added team: IDE team: devx team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team labels Sep 5, 2022
@iQQBot iQQBot marked this pull request as draft September 5, 2022 05:05
@iQQBot
Copy link
Contributor Author

iQQBot commented Sep 5, 2022 •
edited
Loading

it's looks like gke-gcloud-auth-plugin don't support application-default auth and login auth at same time, now if you want to use kubectl connect to GKE cluster, you must set ADC file

@iQQBot iQQBot force-pushed the pd/dev-image-gcloud branch from d942822 to 7232fc6 Compare September 5, 2022 05:29
@roboquat roboquat added size/S and removed size/M labels Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@roboquat roboquat added size/M and removed size/S labels Sep 5, 2022
@iQQBot iQQBot marked this pull request as ready for review September 5, 2022 07:55
@iQQBot
Copy link
Contributor Author

iQQBot commented Sep 8, 2022

Hi @gitpod-io/engineering-self-hosted could you have a look please?

@roboquat roboquat merged commit f02370b into main Sep 8, 2022
@roboquat roboquat deleted the pd/dev-image-gcloud branch September 8, 2022 06:55
@roboquat roboquat added the deployed: IDE IDE change is running in production label Sep 8, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

@vulkoingim vulkoingim vulkoingim approved these changes

@andreafalzetti andreafalzetti andreafalzetti approved these changes

@mrsimonemms mrsimonemms mrsimonemms approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: delivery Issue belongs to the self-hosted team team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iQQBot @mrsimonemms @andreafalzetti @vulkoingim @jenting @roboquat