Replace webapp alerts from jsonnet to YAML #12651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: devx
team: webapp
ArthurSens
commented
Sep 5, 2022
Comment on lines
+118
to
+113
| { | ||
| "gitURL": "https://github.com/gitpod-io/gitpod", | ||
| "path": "operations/observability/mixins/meta/rules", | ||
| }, |
There was a problem hiding this comment.
These same lines will need to be added to all monitoring-satellite apps that we have in argocd
|
/hold because merge needs to be coordinated with changes made to ArgoCD apps |
ArthurSens
force-pushed
the
as/webapp-jsonnetless-alerts
branch
from
29032b0 to
2ef2d5f
Compare
geropl
approved these changes
Sep 5, 2022
vulkoingim
approved these changes
Sep 6, 2022
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
ArthurSens
force-pushed
the
as/webapp-jsonnetless-alerts
branch
from
2ef2d5f to
d0c10c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ArthurSens arthursens2005@gmail.com
Description
As socialized a couple of times before, our colleagues at Gitpod do not work well with Jsonnet, so we're slowly getting rid of all code we have in this language.
With the new observability installer, we're able to import YAML files stored in git. This means that we can replace alerts written in jsonnet with raw YAML that represents the PrometheusRule manifests we need.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: