Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IDE alerts from jsonnet to raw YAML #12658

Merged
merged 2 commits into from
Sep 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .werft/observability/monitoring-satellite.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,12 @@ export class MonitoringSatelliteInstaller {
{
"gitURL": "https://github.com/gitpod-io/observability",
"path": "monitoring-satellite/manifests/probers",
}],
},
{
"gitURL": "https://github.com/gitpod-io/gitpod",
"path": "operations/observability/mixins/IDE/rules",
},
],
},
}' | go run main.go render --config - | kubectl --kubeconfig ${this.options.kubeconfigPath} apply -f -`;
const renderingResult = exec(observabilityInstallerRenderCmd, { silent: false, dontCheckRc: true});
Expand Down
1 change: 0 additions & 1 deletion components/BUILD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ packages:
- install/preview:docker
- install/kots:lint
- components/gitpod-protocol:all
- operations/observability/mixins:lint
- name: docker-versions
type: docker
config:
Expand Down
14 changes: 0 additions & 14 deletions operations/observability/mixins/BUILD.yaml

This file was deleted.

1 change: 0 additions & 1 deletion operations/observability/mixins/IDE/mixin.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@
* Licensed under the MIT License. See License-MIT.txt in the project root for license information.
*/

(import './rules.libsonnet') +
(import './dashboards.libsonnet')
7 changes: 0 additions & 7 deletions operations/observability/mixins/IDE/rules.libsonnet

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

36 changes: 36 additions & 0 deletions operations/observability/mixins/IDE/rules/opensvx-proxy.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Copyright (c) 2022 Gitpod GmbH. All rights reserved.
# Licensed under the GNU Affero General Public License (AGPL).
# See License-AGPL.txt in the project root for license information.

apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
labels:
prometheus: k8s
role: alert-rules
name: openvsx-proxy-monitoring-rules
namespace: monitoring-satellite
spec:
groups:
- name: openvsx-proxy
rules:
- alert: GitpodOpenVSXRegistryDown
labels:
severity: critical
for: 20m
annotations:
runbook_url: https://github.com/gitpod-io/runbooks/blob/main/runbooks/GitpodOpenVsxRegistryDown.md
summary: Open-VSX registry is possibly down
description: Open-VSX registry is possibly down. We cannot pull VSCode extensions we don't have in our caches
expr: |
sum(rate(gitpod_openvsx_proxy_requests_total{status=~"5..|error"}[5m])) / sum(rate(gitpod_openvsx_proxy_requests_total[5m])) > 0.01

- alert: GitpodOpenVSXUnavailable
labels:
severity: warning
team: ide
for: 10m
annotations:
summary: Prometheus is failing to scrape OpenVSX-proxy
description: OpenVSX-proxy is possibly down, or prometheus is failing to scrape it.
expr: up{job="openvsx-proxy"} == 0