-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ide-metrics] add error reporting api #12705
Conversation
75b5c74
to
a7dc039
Compare
I think these endpoints needs authentication so they're not abused so easily |
a7dc039
to
1ddd472
Compare
It is the same as with analytics or observability. We are going to add rate limitting per ip to prevent abuse. Or maybe we already have. The thing is that we did not have problems so far. So I think it should be done separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's bring it 🚀
Description
This PR enrich
ide-metrics
to allow collection of IDE client error logs and reporting them to GCP error logging.On
gitpod.io
we reporting them to GCP, onpreview environment
we write it instdin
, onself-hosted
we ignore it.Related Issue(s)
Fixes #11915
How to test
ide-metrics
logs, it should be log.component
to another value and execute again, it should be reject because component has an allowlist.Release Notes
Documentation
Werft options: