Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send traces from previews to Honeycomb #12781

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Send traces from previews to Honeycomb #12781

merged 1 commit into from
Sep 9, 2022

Conversation

ArthurSens
Copy link
Contributor

@ArthurSens ArthurSens commented Sep 8, 2022

Description

In #12626, I've configured preview environments to always use our CLI installer to install monitoring-satellite. In the process, I accidentally removed the configuration that sends traces from previews to Honeycomb.

This aims to fix that.

Related Issue(s)

Slack conversation

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@ArthurSens
Copy link
Contributor Author

ArthurSens commented Sep 8, 2022

I'm in a constant battle to get a working preview environment to test this 😓

Signed-off-by: ArthurSens <arthursens2005@gmail.com>
@ArthurSens
Copy link
Contributor Author

Alrighty, tested and I can see traces back at honeycomb. The problem is that we don't have the attribute preview.domain anymore, which was used to filter traces from different previews.

image

I've created gitpod-io/observability#308 to follow-up on this problem

@roboquat roboquat merged commit 7a0efe9 into main Sep 9, 2022
@roboquat roboquat deleted the as/preview-tracing branch September 9, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants