[stripe] Finalized invoce debits, do not set credits to negative when updating #12787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
Base automatically changed from
mp/stripe-use-attribution-id-metdata
to
main
September 9, 2022 05:18
svenefftinge
approved these changes
Sep 9, 2022
| @@ -118,7 +108,8 @@ func (s *BillingService) FinalizeInvoice(ctx context.Context, in *v1.FinalizeInv | |||
| ID: uuid.New(), | |||
| AttributionID: attributionID, | |||
| Description: fmt.Sprintf("Invoice %s finalized in Stripe", invoice.ID), | |||
| CreditCents: db.NewCreditCents(float64(creditsOnInvoice)), | |||
| // Apply negative value of credits to reduce accrued credit usage | |||
| CreditCents: db.NewCreditCents(float64(-creditsOnInvoice)), | |||
There was a problem hiding this comment.
Ideally we'd do it the otherway around. Maybe we can create a PR with a migration that negates all credits and changes the respective code as well?
There was a problem hiding this comment.
Actually thinking about it again, it might be fine as is. After all the table is called usage so positive means used negative means gained. 🤷
There was a problem hiding this comment.
We can still make the change and drop the usage records manually
There was a problem hiding this comment.
Spoke directly, we'll be keeping it as is to more closely align with Stripe which also doesn't want negative credits, but positive credits for usage
|
/hold for discussion |
easyCZ
force-pushed
the
mp/stripe-negative-usage
branch
from
27f05d9 to
8bf8561
Compare
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
How to test
Release Notes
Documentation
Werft options: