[usage] Refactor controller package into scheduler #12831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/usage-refactor-controller-package
branch
from
bb0f3f4 to
5f90ea5
Compare
easyCZ
changed the base branch from
main
to
mp/usage-remove-unused-config-and-funcs
Base automatically changed from
mp/usage-remove-unused-config-and-funcs
to
main
September 12, 2022 06:35
easyCZ
force-pushed
the
mp/usage-refactor-controller-package
branch
from
8390b0b to
8b65faa
Compare
# This is the 1st commit message: [usage] Refactor controller package into scheduler # This is the commit message #2: [usage] Refactor controller package into scheduler
easyCZ
force-pushed
the
mp/usage-refactor-controller-package
branch
from
8b65faa to
aa51c3b
Compare
easyCZ
commented
Sep 12, 2022
Comment on lines
53
to
65
| select { | ||
| // attempt a write to signal we want to run | ||
| case r.running <- struct{}{}: | ||
| // we managed to write, there's no other job executing. Cases are not fall through so we continue executing our main logic. | ||
| default: | ||
| // we could not write, so another instance is already running. Skip current run. | ||
| log.Infof("Skipping ledger run, another run is already in progress.") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Mutex logic moves into the job, away from the controller itself. This is needed to allow us to run multiple control loops with the same scheduler.
easyCZ
commented
Sep 12, 2022
| @@ -16,26 +16,26 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| reconcileStartedTotal = prometheus.NewCounterVec(prometheus.CounterOpts{ | |||
| jobStartedSeconds = prometheus.NewCounterVec(prometheus.CounterOpts{ | |||
There was a problem hiding this comment.
These are now general job metrics, rather than specific for the reconcile with ledger. If a job desires more metrics, those can be added in job direclty rather than on the scheduler level.
easyCZ
force-pushed
the
mp/usage-refactor-controller-package
branch
from
aa51c3b to
972ee4f
Compare
easyCZ
force-pushed
the
mp/usage-refactor-controller-package
branch
from
972ee4f to
0d1f67c
Compare
andrew-farries
approved these changes
Sep 13, 2022
easyCZ
force-pushed
the
mp/usage-refactor-controller-package
branch
from
0d1f67c to
f98b45b
Compare
easyCZ
force-pushed
the
mp/usage-refactor-controller-package
branch
from
f98b45b to
675be73
Compare
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor existing controller package into the following:
Related Issue(s)
Fixes #
How to test
Unit
Release Notes
Documentation
Werft options: