Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layer caching by moving apk commands up #12834

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Sep 9, 2022

Description

This moves the apk above the COPY instructions so that we don't invalidate the layers whenever the contents of the files changes ☺️

Related Issue(s)

Fixes #12828

How to test

The Werft build should still succeed. In gitpod-build-mads-improve-layer-caching.3 you can see it did indeed use the cached layer for the apk command.

Release Notes

NONE

Documentation

N/A

Werft options:

  • /werft with-preview

@mads-hartmann
Copy link
Contributor Author

mads-hartmann commented Sep 9, 2022

/werft run

👍 started the job as gitpod-build-mads-improve-layer-caching.2
(with .werft/ from main)

@mads-hartmann
Copy link
Contributor Author

mads-hartmann commented Sep 9, 2022

/werft run

👍 started the job as gitpod-build-mads-improve-layer-caching.3
(with .werft/ from main)

@mads-hartmann mads-hartmann marked this pull request as ready for review September 9, 2022 14:25
@mads-hartmann mads-hartmann requested a review from a team September 9, 2022 14:25
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 9, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit ceb75eb into main Sep 9, 2022
@roboquat roboquat deleted the mads/improve-layer-caching branch September 9, 2022 14:26
@akosyakov
Copy link
Member

It is only 4 secs faster though even with caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build speed: Install/installer:docker
4 participants