[UBP] Fix usage gRPC sugar.ts file
#12843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2022 14:42
In particular avoid the use of `||` against an enum type that can be 0. See: #12767 (comment)
github-actions
bot
added
team: webapp
2 tasks
Definitely. 🔭 We could check out |
svenefftinge
approved these changes
Sep 12, 2022
| return <CostCenter> { | ||
| id: AttributionId.parse(response.getCostCenter()!.getAttributionId()), | ||
|
|
||
| const attrId = AttributionId.parse(response.getCostCenter()!.getAttributionId()); |
There was a problem hiding this comment.
Nit: It would be a contract violation of the GRPC service to return a costCenter without an attributionID. We should enforce the contract in the API impl itself rather than on the TypeScript bindings.
It looked as though |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the
sugar.tsfile that wraps the usage component gRPC client for typescript clients.Use a return value of the correct shape rather than explicitly casting an incorrect shape.
In particular avoid the use of
||against an enum type that can be 0.See #12767 (comment) for the full context.
I really dislike these sugar files, they are an untested, handwritten layer over the generated gRPC client in which bugs like this can lurk.
Related Issue(s)
How to test
Release Notes
Documentation
Werft options: