Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to support on phone verification #12852

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Sep 11, 2022

Description

Following up from #12258, this will duplicate the link to support on the phone verification step when users are entering the mobile phone number, not just the verification code. The reasons behind this change:

  1. We've gotten some from users in China that they are not able to use this feature using their mobile phone number. We're actively working on resolving this with the third-party service we're integrating for this feature, Twilio. See relevant discussion (internal). Cc @svenefftinge @securitymirco @KlasenK
  2. Future errors like this that prevent users from entering a mobile phone number will still end up in the same verification step, which currently doesn't include the link to support as in the next step, which is for entering the verification code.

How to test

  1. Create a new GitHub account and sign in to the preview environment.
  2. Remember to unblock the user in /admin/users. 🎗️
  3. Try opening a new workspace and noticed you'll be prompted to go through the phone verification process.
  4. Notice there's a link to support when entering a mobile phone number.

Release Notes

Add link to support on phone verification

Werft options:

  • /werft with-preview

@gtsiolis gtsiolis requested a review from a team September 11, 2022 13:18
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 11, 2022
@roboquat roboquat merged commit b79164e into main Sep 12, 2022
@roboquat roboquat deleted the gt/add-link-to-support branch September 12, 2022 05:47
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Sep 12, 2022

Danke, @svenefftinge! 🍦

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants