Skip to content

[usage] smaller UI improvements #12858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2022
Merged

[usage] smaller UI improvements #12858

merged 1 commit into from
Sep 13, 2022
+54 −29

Conversation

@svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Sep 12, 2022 •
edited
Loading

Description

Three small UI improvmeents on the usage view:

  • format the total usage number
  • show proper time plus an indicator for running sessions
  • show No sessions found on empty list
  • show viewed range

Related Issue(s)

Fixes #12803

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@svenefftinge svenefftinge requested a review from a team September 12, 2022 06:43
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 12, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-small-usage-ui-impr.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-small-usage-ui-impr.2 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-small-usage-ui-impr.3 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/S and removed size/M labels Sep 12, 2022
@svenefftinge
Copy link
Contributor Author

/hold

@easyCZ
Copy link
Member

easyCZ commented Sep 12, 2022

Thanks for this. I was just about to cut a ticket for the no results issue.

@svenefftinge
Copy link
Contributor Author

I think the build failed because it couldn't remove some workspace pods. The preview environment is running though.
Here's the invite to team gitpod. https://se-small-u7fbb36847c.preview.gitpod-dev.com/teams/join?inviteId=19a93561-1977-4004-ac68-f870319f3458

Screenshot 2022-09-12 at 13 33 58

@svenefftinge svenefftinge requested a review from jldec September 12, 2022 11:35
@svenefftinge
Copy link
Contributor Author

/unhold

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Sep 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run --clean-slate-deployment

👍 started the job as gitpod-build-se-small-usage-ui-impr.7
(with .werft/ from main)

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Sep 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run --with-clean-slate-deployment

👍 started the job as gitpod-build-se-small-usage-ui-impr.8
(with .werft/ from main)

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Sep 13, 2022 •
edited
Loading

@svenefftinge When using the /werft command from GH comments you don't need the -- as Werft will include that in the attribute name so it becomes "--with-clean-slate-deployment" (including "--"). See screenshot

Screenshot 2022-09-13 at 09 47 44

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Sep 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-se-small-usage-ui-impr.9
(with .werft/ from main)

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Sep 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-se-small-usage-ui-impr.11
(with .werft/ from main)

@roboquat roboquat merged commit d86d868 into main Sep 13, 2022
@roboquat roboquat deleted the se/small-usage-ui-impr branch September 13, 2022 09:00
@gtsiolis gtsiolis mentioned this pull request Sep 13, 2022
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jldec jldec Awaiting requested review from jldec

1 more reviewer

@andrew-farries andrew-farries andrew-farries approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Indicate current usage period in usage view, and show text when empty

6 participants

@svenefftinge @easyCZ @mads-hartmann @andrew-farries @roboquat