Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetBrains Backend Plugin] Allow specifying the test-repository when running launch-dev-server.sh #12875

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Sep 12, 2022

Description

Allow passing a test-repository URL via parameter -r when running launch-dev-server.sh for JetBrains Backend Plugin development.

If the parameter is not passed, it will use the default test-repository: https://github.com/gitpod-io/spring-petclinic.

This PR also updates the plugin's path, which is now built with the name "gitpod-remote.zip".

Related Issue(s)

Resolves #10286

How to test

  1. Open the branch of this PR in gitpod.io
  2. Navigate to /workspace/gitpod/components/ide/jetbrains/backend-plugin
  3. Run ./launch-dev-server.sh -r https://github.com/gitpod-io/.github
  4. Confirm it has opened the test environment with https://github.com/gitpod-io/.github repository.
  5. Stop the test environment and run rm -rf /workspace/test-repo.
  6. Run ./launch-dev-server.sh
  7. Confirm it has opened the test environment with https://github.com/gitpod-io/spring-petclinic repository.

Release Notes

NONE

Werft options:

  • /werft with-preview

… launch-dev-server.sh for JetBrains Backend Plugin development

If the parameter is not passed, it will use the default test-repository: https://github.com/gitpod-io/spring-petclinic
@felladrin felladrin self-assigned this Sep 12, 2022
@felladrin felladrin requested a review from a team September 12, 2022 12:23
@felladrin felladrin changed the title [JetBrains Backend Plugin] Allow passing specifying the test-repository when running launch-dev-server.sh [JetBrains Backend Plugin] Allow specifying the test-repository when running launch-dev-server.sh Sep 12, 2022
Copy link
Contributor

@andreafalzetti andreafalzetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised! In a next iteration we could try cleaning up the test-repo dir or, use a dynamic name (e.g. the name of the cloned repo) so that we don't have to manually remove the files.

@roboquat roboquat merged commit 8c035ef into main Sep 13, 2022
@roboquat roboquat deleted the felladrin/10286 branch September 13, 2022 15:27
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note-none size/S team: IDE
Projects
None yet
3 participants