-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UBP] Add subscribeToStripe
server method
#12887
Conversation
started the job as gitpod-build-af-server-subscribe-user-to-stripe.10 because the annotations in the pull request description changed |
started the job as gitpod-build-af-server-subscribe-user-to-stripe.11 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a couple of comments.
/hold if you want to tackle the comments
Generalize the `subscribeTeamToStripe` method so that it works for user attribution ids too. Implement the `subscribeTeamToStripe` method in terms of the new general method.
12695f8
to
4b2e3e2
Compare
/unhold |
Description
Add a general method
subscribeToStripe
to the server JSON-RPC API for adding Stripe subscriptions to a Stripe customer, for customers representing teams or individual users.Implement the existing
subscribeTeamToStripe
method (which only worked for teams) in terms of the new method.The more general method will be used to subscribe individual Stripe users in subsequent PRs.
Related Issue(s)
Part of #12685
How to test
The flow to sign a team up for UBP still works:
Gitpod
in the name.Release Notes
Documentation
Werft options: