Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UBP] Add subscribeToStripe server method #12887

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Sep 12, 2022

Description

Add a general method subscribeToStripe to the server JSON-RPC API for adding Stripe subscriptions to a Stripe customer, for customers representing teams or individual users.

Implement the existing subscribeTeamToStripe method (which only worked for teams) in terms of the new method.

The more general method will be used to subscribe individual Stripe users in subsequent PRs.

Related Issue(s)

Part of #12685

How to test

The flow to sign a team up for UBP still works:

  1. Create a team with Gitpod in the name.
  2. Sign the team up for UBP from the billing tab on the team settings page.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-server-subscribe-user-to-stripe.10 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-server-subscribe-user-to-stripe.11 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple of comments.

/hold if you want to tackle the comments

Andrew Farries added 2 commits September 13, 2022 06:08
Generalize the `subscribeTeamToStripe` method so that it works for user
attribution ids too.

Implement the `subscribeTeamToStripe` method in terms of the new general
method.
@andrew-farries andrew-farries force-pushed the af/server-subscribe-user-to-stripe branch from 12695f8 to 4b2e3e2 Compare September 13, 2022 06:11
@andrew-farries
Copy link
Contributor Author

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants