Remove deprecated sendFeedback server method #12911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
jx/rm-old-feedback
branch
from
7f35a7b to
e7d5091
Compare
|
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-jx-rm-old-feedback.2 |
|
Werft was having too much trouble with this -- moving on to #12918. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated
sendFeedbackserver method.Note: This is completely unrelated to the new dashboard feedback mechanism. 💡
In the early days of Gitpod (I think when it was still in Beta, or fresh out of Beta) there was a simple mechanism to provide general feedback about Gitpod, and in exchange you would receive a credit of 50 bonus Gitpod hours.
This feature no longer exists, and we no longer even keep track of the provided feedback (it's logged at
infolevel in server, which we currently discard), but the server method is still there in our API, potentially allowing clever users to credit themselves 50 hours whenever they want.This PR removes the old, deprecated
sendFeedbackmethod. Also, removing it now is a good idea, because we have a new dashboard feedback mechanism in place, and it's too easy to accidentally mistake one for the other.Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: