[usage] Track last compelted ledger job time #12961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
commented
Sep 14, 2022
| @@ -37,51 +34,6 @@ func NewPeriodicJobSpec(period time.Duration, id string, job Job) (JobSpec, erro | |||
| }, nil | |||
| } | |||
|
|
|||
| func NewLedgerTriggerJobSpec(schedule time.Duration, job Job) (JobSpec, error) { | |||
There was a problem hiding this comment.
This is moved into separate file to make navigation a bit easier.
easyCZ
commented
Sep 14, 2022
Comment on lines
+33
to
+35
| defer func() { | ||
| reportLedgerCompleted(err) | ||
| }() |
There was a problem hiding this comment.
This is the only change in logic - reporting the metric
andrew-farries
approved these changes
Sep 15, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Gauge metric which tracks the last time we completed a scheduled ledger reconciliation. We'll use this metric to setup an alert for when we haven't completed a run succesfully for more than 1h (which could cause us to have gaps in the data).
This metric is setup the same way as other standard kube metrics- see example
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: