Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer-tests] Surround the GCP password with quotes #12985

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

This PR fixes the occasional GCP database connection failures that happen in running automated tests. Since we allow special characters, sometimes this causes errors in yq m command we use to merge configs.

Related Issue(s)

Fixes #

How to test

werft run github -j .werft/gke-installer-tests.yaml -a deps=external

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@nandajavarma nandajavarma requested a review from a team September 15, 2022 07:58
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 15, 2022
@roboquat roboquat merged commit 5ed8a4a into main Sep 15, 2022
@roboquat roboquat deleted the nvn/fix-gcp-db-pwd branch September 15, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants