-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kots]: change to the new installer config commands #12986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
changed the title
Sje/kots refactoring
[kots]: change to the new installer config commands
Sep 15, 2022
1 task
mrsimonemms
force-pushed
the
sje/kots-refactoring
branch
from
September 15, 2022 09:26
3985782
to
64b5592
Compare
mrsimonemms
changed the base branch from
main
to
sje/installer-config-build
September 15, 2022 16:17
mrsimonemms
force-pushed
the
sje/kots-refactoring
branch
from
September 15, 2022 16:19
64b5592
to
2f428fd
Compare
mrsimonemms
force-pushed
the
sje/installer-config-build
branch
from
September 15, 2022 16:23
d1063d3
to
a3941fa
Compare
mrsimonemms
force-pushed
the
sje/kots-refactoring
branch
from
September 15, 2022 16:23
2f428fd
to
19c6167
Compare
mrsimonemms
changed the base branch from
sje/installer-config-build
to
main
September 16, 2022 12:10
github-actions
bot
added
the
team: delivery
Issue belongs to the self-hosted team
label
Sep 16, 2022
/hold for #12687 |
mrsimonemms
force-pushed
the
sje/kots-refactoring
branch
from
September 20, 2022 07:11
19c6167
to
1594b5a
Compare
Contributor
Author
/werft run 👍 started the job as gitpod-build-sje-kots-refactoring.5 |
mrsimonemms
force-pushed
the
sje/kots-refactoring
branch
from
September 20, 2022 15:00
1594b5a
to
9e25b5b
Compare
/unhold |
Pothulapati
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks straightforward, and with all the test suites in the PR it seems to work as expected!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configures the KOTS installer to use the shiny new Installer
config
commands.The
kots-install.sh
still merges the Docker config JSON files. Ultimately, this will live in the Installer binary, but that work is not yet ready as dependent upon #12060.This requires #12687 to be merged first
Related Issue(s)
Fixes #12984
How to test
Install via KOTS. As this changes the whole installation process, we should confirm that all the normal deployment tests run. When test passed satisfactorily, please check it and put your name:
Release Notes
Documentation
Werft options: