Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kots]: change to the new installer config commands #12986

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Sep 15, 2022

Description

Configures the KOTS installer to use the shiny new Installer config commands.

The kots-install.sh still merges the Docker config JSON files. Ultimately, this will live in the Installer binary, but that work is not yet ready as dependent upon #12060.

This requires #12687 to be merged first

Related Issue(s)

Fixes #12984

How to test

Install via KOTS. As this changes the whole installation process, we should confirm that all the normal deployment tests run. When test passed satisfactorily, please check it and put your name:

Release Notes

[kots]: change to the new installer config commands

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms changed the title Sje/kots refactoring [kots]: change to the new installer config commands Sep 15, 2022
@mrsimonemms mrsimonemms mentioned this pull request Sep 15, 2022
1 task
@mrsimonemms mrsimonemms changed the base branch from main to sje/installer-config-build September 15, 2022 16:17
@roboquat roboquat added size/XL and removed size/XXL labels Sep 15, 2022
@mrsimonemms mrsimonemms force-pushed the sje/installer-config-build branch from d1063d3 to a3941fa Compare September 15, 2022 16:23
@mrsimonemms mrsimonemms changed the base branch from sje/installer-config-build to main September 16, 2022 12:10
@mrsimonemms mrsimonemms marked this pull request as ready for review September 16, 2022 12:10
@mrsimonemms mrsimonemms requested a review from a team September 16, 2022 12:10
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 16, 2022
@mrsimonemms
Copy link
Contributor Author

/hold for #12687

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Sep 20, 2022

/werft run

👍 started the job as gitpod-build-sje-kots-refactoring.5
(with .werft/ from main)

@mrsimonemms
Copy link
Contributor Author

/unhold

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks straightforward, and with all the test suites in the PR it seems to work as expected!

@roboquat roboquat merged commit 9f95354 into main Sep 21, 2022
@roboquat roboquat deleted the sje/kots-refactoring branch September 21, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XL team: delivery Issue belongs to the self-hosted team
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Wire up the code changes in KOTS
3 participants