[usage] Handle customer.subscription.deletedevent from Stripe
#13016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-se-stripe-cancellation.1 because the annotations in the pull request description changed |
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
svenefftinge
changed the title
svenefftinge
force-pushed
the
se/stripe-cancellation
branch
from
ef44216 to
d4853d2
Compare
svenefftinge
force-pushed
the
se/stripe-cancellation
branch
from
d4853d2 to
600d13d
Compare
svenefftinge
force-pushed
the
se/stripe-cancellation
branch
from
600d13d to
a3d2eab
Compare
svenefftinge
changed the title
customer.subscription.deletedevent form Stripe
svenefftinge
changed the title
customer.subscription.deletedevent form Stripecustomer.subscription.deletedevent from Stripe
svenefftinge
force-pushed
the
se/stripe-cancellation
branch
from
a3d2eab to
2365191
Compare
easyCZ
reviewed
Sep 16, 2022
svenefftinge
force-pushed
the
se/stripe-cancellation
branch
from
2365191 to
1bb1ab3
Compare
easyCZ
approved these changes
Sep 16, 2022
| @@ -244,6 +245,19 @@ func (c *Client) GetInvoice(ctx context.Context, invoiceID string) (*stripe.Invo | |||
| return invoice, nil | |||
| } | |||
|
|
|||
| func (c *Client) GetAttributionIdForSubscriptionId(ctx context.Context, subscriptionID string) (db.AttributionID, error) { | |||
There was a problem hiding this comment.
I think we could use this method in the FinalizeInvoice RPC now
https://github.com/gitpod-io/gitpod/pull/13016/files#diff-0d6333b0d3d47166ad0d69ee3f28afaa9bb48eeb72de0e648582fa3852def7fcR76-R86
Comment on lines
135
to
147
| // we don't manage stripe billing cycle | ||
| costCenter.NextBillingTime = VarcharTime{} | ||
| } else if costCenter.BillingStrategy == CostCenter_Other { | ||
| // cancelled from stripe reset the spending limit | ||
| if costCenter.ID.IsEntity(AttributionEntity_Team) { | ||
| costCenter.SpendingLimit = c.cfg.ForTeams | ||
| } else { | ||
| costCenter.SpendingLimit = c.cfg.ForUsers | ||
| } | ||
| // see you next month | ||
| costCenter.NextBillingTime = NewVarcharTime(now.AddDate(0, 1, 0)) |
There was a problem hiding this comment.
I think the individual field assignment into a CostCenter object really hurts readability here. The alternative approach is to construct the CostCenter in each branch seperately (with some possible duplication) but making it very explicit what each branch will result in.
Comment on lines
+26
to
+29
| invoiceUpdatedEventType = "invoice.updated" | ||
| invoiceFinalizedEventType = "invoice.finalized" | ||
| customerCreatedEventType = "customer.created" | ||
| customerSubscriptionDeleted = "customer.subscription.deleted" |
There was a problem hiding this comment.
Might make sense to move these as consts in the stripe.go file and re-use in tests
svenefftinge
force-pushed
the
se/stripe-cancellation
branch
3 times, most recently
from
1bb1ab3 to
be4ee50
Compare
This API is called by Stripe when a customer cancels their subscription
This event is fired by Stripe when a customer cancels their subscription
svenefftinge
force-pushed
the
se/stripe-cancellation
branch
from
be4ee50 to
ca5ac1f
Compare
|
/unhold |
This was referenced Sep 16, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user cancels their subscription, we get an event from Stripe, which we need to handle in order to update our system.
This PR does
CancelSubscriptionon usage-apicustomer.subscription.deletedevent in public-api-server which callsCancelSubscriptionCancelSubscriptionin usage.Related Issue(s)
See #13010
How to test
Release Notes
Documentation
Werft options: