Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove d_b_workspace_instance_usage from TableDescriptionProvider #13025

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Remove d_b_workspace_instance_usage from the table description provider that db-sync uses to generate a list of tables to sync.

This table was removed from the db in #12948.

With this non-existent table present in the list db-sync would show a warning on every sync:

{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","serviceContext":{"service":"db-sync","version":"<ts-not-set>"},"component":"db-sync","severity":"WARNING","time":"2022-09-16T07:51:10.741Z","message":"table d_b_workspace_instance_usage does not exist - not replicating"}

Related Issue(s)

Relates to #12948.

How to test

Hard to test as we don't run db-sync in preview.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

This table was removed from the db in #12948.
@andrew-farries andrew-farries marked this pull request as ready for review September 16, 2022 08:28
@andrew-farries andrew-farries requested a review from a team September 16, 2022 08:28
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 16, 2022
@andrew-farries
Copy link
Contributor Author

andrew-farries commented Sep 16, 2022

/werft run

👍 started the job as gitpod-build-af-remove-table-from-table-description-provid.2
(with .werft/ from main)

@easyCZ
Copy link
Member

easyCZ commented Sep 16, 2022

Thank you!

@roboquat roboquat merged commit 785c2a1 into main Sep 16, 2022
@roboquat roboquat deleted the af/remove-table-from-table-description-provider branch September 16, 2022 08:34
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants